[ENH] V1 → V2 API Migration - evaluations#1606
Merged
PGijsbers merged 247 commits intoopenml:mainfrom Mar 24, 2026
Merged
Conversation
fkiraly
previously requested changes
Jan 7, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
looks like circular imports
Contributor
Author
|
@geetu040 We have circular imports here cuz of importing Error message: |
geetu040
suggested changes
Jan 13, 2026
Collaborator
geetu040
left a comment
There was a problem hiding this comment.
Please update the listing functionality with the suggested approach in #1575 (comment). And also sync this PR with my base PR.
This reverts commit 93155ee.
geetu040
suggested changes
Mar 13, 2026
Collaborator
geetu040
left a comment
There was a problem hiding this comment.
update with #1576 (comment)
geetu040
approved these changes
Mar 24, 2026
Collaborator
geetu040
left a comment
There was a problem hiding this comment.
@EmanAbdelhaleem Thanks for the PR. Nicely done!
I have updated the PR to sync with latest changes in base PR.
@PGijsbers please review/merge.
I am happy whenever @PGijsbers is happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1623
Depends on #1576
Related to #1575
Details
This PR implements
Evaluationsresource, and refactor its existing functions