Skip to content

Release 0.24.5#71

Merged
maaktweluit merged 3 commits intomasterfrom
mwu/v0.25.0
Mar 3, 2020
Merged

Release 0.24.5#71
maaktweluit merged 3 commits intomasterfrom
mwu/v0.25.0

Conversation

@maaktweluit
Copy link
Copy Markdown
Contributor

@maaktweluit maaktweluit commented Mar 2, 2020

While testing this branch i found out #67 is not compatible with golem-core, since it uses peewee==2.10.2, created #70

Updates the version to 0.24.5 for release of pending issues.

@maaktweluit maaktweluit requested review from etam and shadeofblue March 2, 2020 12:44
@maaktweluit maaktweluit self-assigned this Mar 2, 2020
@etam
Copy link
Copy Markdown

etam commented Mar 2, 2020

Why move to requirements-test.txt?

@maaktweluit
Copy link
Copy Markdown
Contributor Author

@etam exactly what i though when moving it to setup.py.

Turns out there was a hack in place to not have golem update to peewee==3.11 this is why i moved it back to requirements-test.txt and created #70 to fix it

@etam
Copy link
Copy Markdown

etam commented Mar 3, 2020

#70 makes a lot of sense.

Why 0.25.0, not 0.24.5?

@maaktweluit
Copy link
Copy Markdown
Contributor Author

new ( optional ) argument to entrypoint.py

so officially according to semver it should be a new minor version, i was thinking of making it a patch update before, so checked the manual ;)

if you insist i'm fine with making it a patch

@etam
Copy link
Copy Markdown

etam commented Mar 3, 2020

After inspecting 0.24.4...mwu/v0.25.0 it seems to me, that it should be 0.24.5 instead.

Apart from that, I have no more objections.

@maaktweluit maaktweluit changed the title Release 0.25.0 Release 0.24.5 Mar 3, 2020
@maaktweluit
Copy link
Copy Markdown
Contributor Author

@etam updated!

Copy link
Copy Markdown

@etam etam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@maaktweluit maaktweluit merged commit d25fdfe into master Mar 3, 2020
@maaktweluit maaktweluit deleted the mwu/v0.25.0 branch March 3, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants