Moved peewee dependency from requirements-test to install_requires#67
Merged
maaktweluit merged 1 commit intomasterfrom Feb 26, 2020
Merged
Moved peewee dependency from requirements-test to install_requires#67maaktweluit merged 1 commit intomasterfrom
maaktweluit merged 1 commit intomasterfrom
Conversation
mfranciszkiewicz
approved these changes
Feb 25, 2020
maaktweluit
commented
Feb 25, 2020
| 'grpclib==0.2.4', | ||
| 'protobuf==3.7.1', | ||
| ], | ||
| setup_requires=[ |
Contributor
Author
There was a problem hiding this comment.
setup_requires is for extra packages that are not required for bundling and installing the library: https://blog.godatadriven.com/setup-py
no need to have all packages duplicated here
This was referenced Mar 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems it was added in the wrong place