[doc] Add release notes v1.52.0#24357
Conversation
rpoyner-tri
left a comment
There was a problem hiding this comment.
FYI @jwnimmer-tri here's your chance to copy-edit announcements.
@rpoyner-tri made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.
|
I've pushed my edits. Patch pumpkin is back to you. |
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
doc/_release-notes/v1.52.0.md line 21 at r1 (raw file):
* GCC >= 13 ([#24232][_#24232]) * Clang >= 20 ([#24232][_#24232], [#24275][_#24275]) * Apple LLVM >= 17 (Xcode >= 26.3) ([#24232][_#24232])
nit this is not new as documented, unless you wanted to announce the fix in CMakeLists.txt to make the build warn. I'm not sure I see the gain.
However, per my other thread, up to y'all to decide whether something like "Apple LLVM >= 21 (Xcode 26.4)" on macOS Tahoe only is worth a mention up here.
doc/_release-notes/v1.52.0.md line 25 at r1 (raw file):
* fmt >= 9.1 ([#24223][_#24223]) * spdlog >= 1.12 ([#24223][_#24223]). * As previously announcted, Drake is switching to a new AutoDiff implementation
nit typo
Suggestion:
As previously announceddoc/_release-notes/v1.52.0.md line 207 at r1 (raw file):
* Update supported Clang on Ubuntu to 20 ([#24275][_#24275]) * Update supported macOS CMake to 4.3 ([#24277][_#24277]) * Update supported macOS Xcode to 26.4 ([#24277][_#24277])
nit clarity
Suggestion:
Update supported Xcode on macOS Tahoe to 26.4
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 2 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on tyler-yankee).
doc/_release-notes/v1.52.0.md line 21 at r1 (raw file):
Previously, tyler-yankee (Tyler Yankee) wrote…
nit this is not new as documented, unless you wanted to announce the fix in CMakeLists.txt to make the build warn. I'm not sure I see the gain.
However, per my other thread, up to y'all to decide whether something like "Apple LLVM >= 21 (Xcode 26.4)" on macOS Tahoe only is worth a mention up here.
Yes, this is announcing the new minimum bar, as expressed in the warning. Same as the GCC >= 13 and Clang >= 20 immediately above.
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee reviewed 1 file and all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
LGTM so far.
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
doc/_release-notes/v1.52.0.md line 101 at r6 (raw file):
New features * Allow CENIC to accept nested diagrams ([#24207][_#24207])
BTW Do we want to say CENIC or CenicIntegrator?
Ditto throughout.
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
stamp to unblock for tomorrow.
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
(I just pushed my final round of copy editing.)
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
rpoyner-tri
left a comment
There was a problem hiding this comment.
-(status: defer ci)
@rpoyner-tri made 1 comment.
Reviewable status: needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri).
rpoyner-tri
left a comment
There was a problem hiding this comment.
+(status: single reviewer ok)
@rpoyner-tri made 1 comment.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri).
doc/_release-notes/v1.52.0.md line 192 at r14 (raw file):
* Enable OpenMP by default on Linux ([#24370][_#24370]) * Promote ca-certificates to binary prereqs (from build) ([#24398][_#24398]) * Add some build dependencies to our apt package release ([#24399][_#24399])
These are in the wrong spot. I'll push a fix.
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
doc/_release-notes/v1.52.0.md line 192 at r14 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
These are in the wrong spot. I'll push a fix.
Done
|
BTW Maybe this might not be obvious, but any invocation of The fact that |
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
|
hm, these Jammy release artifacts won't exist. Is the base of this branch outdated? Code quote: * [https://github.com/RobotLocomotion/drake/releases/download/v1.52.0/drake-1.52.0-jammy.tar.gz](https://github.com/RobotLocomotion/drake/releases/download/v1.52.0/drake-1.52.0-jammy.tar.gz) |
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee reviewed 1 file and all commit messages.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on tyler-yankee).
doc/_pages/from_binary.md line 38 at r16 (raw file):
Previously, tyler-yankee (Tyler Yankee) wrote…
hm, these Jammy release artifacts won't exist. Is the base of this branch outdated?
Master doesn't have any novel fixes here. This is just a line that we need to delete by hand in the first release that doesn't have Jammy, which is this one.
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri made 1 comment.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri and tyler-yankee).
doc/_pages/from_binary.md line 38 at r16 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Master doesn't have any novel fixes here. This is just a line that we need to delete by hand in the first release that doesn't have Jammy, which is this one.
Done.
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee reviewed 1 file and all commit messages.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri).
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 1 file.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on jwnimmer-tri).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on rpoyner-tri).
rpoyner-tri
left a comment
There was a problem hiding this comment.
+(status: squashing now)
@rpoyner-tri made 1 comment.
Reviewable status:complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on rpoyner-tri).
This change is