Refactor HashTableSeparateChaining: encapsulate Entry, fix iterator, simplify API#1316
Merged
williamfiset merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
…simplify API Make Entry a private static inner class. Remove redundant method aliases (add/insert/hasKey) in favor of put/containsKey. Add dedicated modCount for fail-fast iteration instead of using size as a proxy. Rewrite iterator so hasNext() is idempotent. Use single-pass iterator removal in removeEntry to avoid double linear scan. Remove unnecessary bucket.clear() in resize. Add educational comments on key implementation details. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Entrya private static inner class instead of top-level package-privateadd/insert/hasKey) — keepput/containsKeymodCountfor fail-fast iteration (was usingsizeas proxy)hasNext()is idempotent and doesn't advance stateremoveEntryto avoid double linear scanbucket.clear()inresizeTableTest plan
bazel test //src/test/java/com/williamfiset/algorithms/datastructures/hashtable:HashTableSeparateChainingTest— all tests pass🤖 Generated with Claude Code