Merged
Conversation
gatesn
reviewed
Nov 4, 2025
| ) -> VortexResult<()> { | ||
| let len = offsets.len(); | ||
|
|
||
| match_each_integer_pvector!(&offsets, |offsets_vector| { |
Contributor
There was a problem hiding this comment.
You can actually just match_each_native_ptype!(offsets.ptype(), |T| offsets.into::<PVector<T>>()) I think
Contributor
Author
There was a problem hiding this comment.
Should we keep the macros I wrote for completeness?
Contributor
There was a problem hiding this comment.
If you don't need them, then no
Contributor
Author
There was a problem hiding this comment.
Ok I banged my head for a while and basically if we want to do it this way then we need to have a downcast that doesnt take ownership. I think it might be worth adding as_ methods to the primitive and decimal vectors
gatesn
approved these changes
Nov 4, 2025
784366b to
6909a69
Compare
gatesn
approved these changes
Nov 5, 2025
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
6909a69 to
84b0ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #5028
This PR adds the
ListVectortype and the basic operations EXCEPTsplit_offandunsplit(as we probably should figure that out withbinaryview).More docs can come later once more methods are added (we probably also want a
get_listkind of method).