Skip to content

Chore: add immutable validity for mutable vectors#5188

Merged
gatesn merged 1 commit intodevelopfrom
ct/vv-validity-mut
Nov 4, 2025
Merged

Chore: add immutable validity for mutable vectors#5188
gatesn merged 1 commit intodevelopfrom
ct/vv-validity-mut

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

@connortsui20 connortsui20 commented Nov 4, 2025

Tracking Issue: #5028

@connortsui20 connortsui20 requested review from a10y and gatesn November 4, 2025 19:09
@connortsui20 connortsui20 added the changelog/feature A new feature label Nov 4, 2025
@connortsui20 connortsui20 mentioned this pull request Nov 4, 2025
39 tasks
Copy link
Copy Markdown
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to do this or to provide a is_valid(index: usize) accessor? why would you want to access the validity before freezing?

@connortsui20
Copy link
Copy Markdown
Contributor Author

connortsui20 commented Nov 4, 2025

I need it to access child validities for ListVector validation (need to check that there are no nulls in offsets and sizes), and tbh this seems like a nice thing to have in general

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.04%. Comparing base (d2272a3) to head (c3f870f).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/binaryview/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/bool/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/decimal/generic_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/decimal/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/fixed_size_list/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/null/vector_mut.rs 72.72% 3 Missing ⚠️
vortex-vector/src/primitive/generic_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/primitive/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/struct_/vector_mut.rs 0.00% 3 Missing ⚠️
vortex-vector/src/vector_mut.rs 0.00% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 4d2d47d into develop Nov 4, 2025
40 checks passed
@gatesn gatesn deleted the ct/vv-validity-mut branch November 4, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants