Chore: add docs and tests for decimal vectors#5185
Merged
connortsui20 merged 1 commit intodevelopfrom Nov 4, 2025
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a10y
reviewed
Nov 4, 2025
Comment on lines
+37
to
+39
| /// use vortex_dtype::{DecimalDType, PrecisionScale}; | ||
| /// use vortex_vector::{DVectorMut, VectorMutOps}; | ||
| /// |
Contributor
There was a problem hiding this comment.
usually i try and # out the import blocks in doc tests
Contributor
Author
There was a problem hiding this comment.
For the longer examples like these I find that I am usually copy and pasting it somewhere else, and in these cases I actually get really annoyed when imports are hidden. For smaller examples though I agree
a10y
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #5028
Note that I'm probably going to move where this is placed in the next PR but the content will be the same.