Conversation
48454fa to
387a1a7
Compare
387a1a7 to
4d86b96
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| /// Gets a nullable element at the given index. | ||
| /// Gets a nullable element at the given index, **WITHOUT** bounds checking. |
There was a problem hiding this comment.
This isn't true? It panics on out of bounds?
There was a problem hiding this comment.
What I really mean is that it does not follow the behavior of slice::get which returns an option on out of bounds... Not really sure of a better way to summarize this? I could also just remove that statement and force everyone to read the whole docs.
There was a problem hiding this comment.
I reworded it to panicking on out-of-bounds.
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Adds `with_capacity` and other constructors for the mutable decimal vectors, and additionally moves more things around. I also removed the get method since it now returns a reference since you can just call `.as_ref()` and call the native `slice::get` method. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
4d86b96 to
189f330
Compare
Tracking Issue: #5028
Adds a bunch of missing methods plus reorganizes things to be in line with the other existing vectors.
There's also no tests for decimal vectors at all but that can come later...