Conversation
1267994 to
3738356
Compare
3738356 to
e9aee83
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // valid buffer indices in the current array. | ||
| let mut buf_index_lookup: Vec<u32> = Vec::with_capacity(other.buffers().len()); | ||
| let mut new_buffers = Vec::new(); | ||
| for buffer in other.buffers().iter() { |
There was a problem hiding this comment.
If you assume the buffers are unique, then don't you just need to offset all the indices by n = self.buffers.len()?
There was a problem hiding this comment.
But after merging the buffer points might be out of order now, so we can't just do a blanket offset.
E.g. if self has buffers [buf1, buf2] and other has buffers [buf3, buf1, buf4, buf2]
There was a problem hiding this comment.
I guess I assumed we just wouldn't de-dupe? As in, it doesn't really matter if other has buf1 or buf2, can just treat them as new buffers.
There was a problem hiding this comment.
The existing builders do have some logic to try and dedupe that I figured we'd want to carry over, but if not then that certainly makes things simpler.
There was a problem hiding this comment.
I removed the deduping logic in favor of trivial appending
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
ead8e7c to
2c7a641
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Tracking Issue: #5028