Skip to content

Add decimal vectors#5124

Merged
gatesn merged 8 commits intodevelopfrom
ngates/decimal-vector2
Oct 30, 2025
Merged

Add decimal vectors#5124
gatesn merged 8 commits intodevelopfrom
ngates/decimal-vector2

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Oct 30, 2025

Tracking Issue: #5028

Missing from iterator and other construction functions, but the bones are there

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from a10y October 30, 2025 16:38
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/feature A new feature label Oct 30, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 2.27743% with 472 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.79%. Comparing base (1cb3f21) to head (f778720).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/decimal/vector_mut.rs 0.00% 92 Missing ⚠️
vortex-vector/src/decimal/generic.rs 0.00% 71 Missing ⚠️
vortex-vector/src/decimal/vector.rs 0.00% 68 Missing ⚠️
vortex-dtype/src/decimal/precision.rs 0.00% 59 Missing ⚠️
vortex-vector/src/decimal/generic_mut.rs 0.00% 36 Missing ⚠️
vortex-compute/src/arrow/decimal.rs 0.00% 31 Missing ⚠️
vortex-vector/src/decimal/generic_mut_impl.rs 0.00% 20 Missing ⚠️
vortex-vector/src/decimal/mod.rs 0.00% 18 Missing ⚠️
vortex-compute/src/arrow/varbin.rs 0.00% 16 Missing ⚠️
vortex-compute/src/arrow/struct_.rs 0.00% 15 Missing ⚠️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #5124 will degrade performances by 18.19%

Comparing ngates/decimal-vector2 (f778720) with develop (1cb3f21)

Summary

❌ 75 regressions
✅ 1243 untouched
🆕 7 new
⏩ 99 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
chunked_dict_primitive_canonical_into[f32, (1000, 10, 10)] 90.3 µs 104.3 µs -13.41%
chunked_dict_primitive_canonical_into[f32, (1000, 10, 100)] 698.2 µs 811.9 µs -14%
chunked_dict_primitive_canonical_into[f32, (1000, 100, 10)] 94.1 µs 108.2 µs -13%
chunked_dict_primitive_canonical_into[f32, (1000, 100, 100)] 714.5 µs 827.1 µs -13.61%
chunked_dict_primitive_canonical_into[f32, (1000, 1000, 10)] 112 µs 126.1 µs -11.21%
chunked_dict_primitive_canonical_into[f32, (1000, 1000, 100)] 901.9 µs 1,017.9 µs -11.4%
chunked_dict_primitive_canonical_into[f64, (1000, 10, 10)] 118 µs 132.6 µs -10.97%
chunked_dict_primitive_canonical_into[f64, (1000, 10, 100)] 985.1 µs 1,107.7 µs -11.07%
chunked_dict_primitive_canonical_into[f64, (1000, 100, 10)] 124.7 µs 139.5 µs -10.62%
chunked_dict_primitive_canonical_into[f64, (1000, 100, 100)] 988.8 µs 1,112.2 µs -11.09%
chunked_dict_primitive_canonical_into[u32, (1000, 10, 10)] 90.5 µs 104.4 µs -13.36%
chunked_dict_primitive_canonical_into[u32, (1000, 10, 100)] 717.3 µs 832.1 µs -13.8%
chunked_dict_primitive_canonical_into[u32, (1000, 100, 10)] 92.1 µs 106.1 µs -13.17%
chunked_dict_primitive_canonical_into[u32, (1000, 100, 100)] 721.6 µs 835.7 µs -13.65%
chunked_dict_primitive_canonical_into[u32, (1000, 1000, 10)] 109.7 µs 123.9 µs -11.45%
chunked_dict_primitive_canonical_into[u32, (1000, 1000, 100)] 901.8 µs 1,018.2 µs -11.43%
chunked_dict_primitive_canonical_into[u64, (1000, 10, 10)] 118.8 µs 132.7 µs -10.46%
chunked_dict_primitive_canonical_into[u64, (1000, 10, 100)] 960.6 µs 1,076.6 µs -10.77%
chunked_dict_primitive_canonical_into[u64, (1000, 100, 10)] 123.6 µs 138.1 µs -10.51%
chunked_dict_primitive_canonical_into[u64, (1000, 100, 100)] 1 ms 1.1 ms -10.55%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 99 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn enabled auto-merge (squash) October 30, 2025 17:54
@connortsui20 connortsui20 self-requested a review October 30, 2025 17:59
@connortsui20 connortsui20 mentioned this pull request Oct 30, 2025
39 tasks
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 8945cd8 into develop Oct 30, 2025
39 of 40 checks passed
@gatesn gatesn deleted the ngates/decimal-vector2 branch October 30, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants