Looping class-string-map incorrectly has mixed key and mixed value

[kkmuffme]

Using the example from the docs https://psalm.dev/docs/annotating_code/type_syntax/utility_types/#class-string-mapt-of-foo-t

When looping over the class-string-map it incorrectly uses mixed instead of class-string<Foo> for the key and Foo for the value
https://psalm.dev/r/d4aa6104f1

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d4aa6104f1

<?php

/**
 * @psalm-consistent-constructor
 */
class Foo {}

/**
 * @psalm-consistent-constructor
 */
class Bar extends Foo {}

class A {
  /** @var class-string-map<T of Foo, T> */
  private static array $map = [];

  /**
   * @template U of Foo
   * @param class-string<U> $class
   * @return U
   */
  public static function get(string $class) : Foo {
    if (isset(self::$map[$class])) {
      return self::$map[$class];
    }
      
    foreach (self::$map as $class_name => $instance) {
        /** @psalm-trace $class_name */;   
        /** @psalm-trace $instance */;
    }

    self::$map[$class] = new $class();
    return self::$map[$class];
  }
}

$foo = A::get(Foo::class);
$bar = A::get(Bar::class);

/** @psalm-trace $foo */; // Foo
/** @psalm-trace $bar */; // Bar

Psalm output (using commit d9c7477):

INFO: Trace - 40:25 - $foo: Foo

INFO: Trace - 41:25 - $bar: Bar

INFO: MixedAssignment - 27:28 - Unable to determine the type that $class_name is being assigned to

INFO: MixedAssignment - 27:43 - Unable to determine the type that $instance is being assigned to

INFO: Trace - 28:40 - $class_name: mixed

INFO: Trace - 29:38 - $instance: mixed

ERROR: MissingPureAnnotation - 22:26 - get must be marked @psalm-external-mutation-free to aid security analysis, run with --alter --issues=MissingPureAnnotation to fix this

[kkmuffme]

And array_values() and docblock value-of are also broken for class-string-map and result in a completely wrong type of int<0, max>
https://psalm.dev/r/57903811bc

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/57903811bc

<?php

/**
 * @psalm-consistent-constructor
 */
class Foo {}

/**
 * @psalm-consistent-constructor
 */
class Bar extends Foo {}

class A {
  /** @var class-string-map<T of Foo, T> */
  private static array $map = [];

  /**
   * @template U of Foo
   * @param class-string<U> $class
   * @return U
   */
  public static function get(string $class) : Foo {
    if (isset(self::$map[$class])) {
      return self::$map[$class];
    }
      
      $x = array_values( self::$map );
      /** @psalm-trace $x */;
      
      
    foreach ($x as $class_name => $instance) {
        /** @psalm-trace $class_name */;   
        /** @psalm-trace $instance */;
    }

    self::$map[$class] = new $class();
    return self::$map[$class];
  }
}

$foo = A::get(Foo::class);
$bar = A::get(Bar::class);

/** @psalm-trace $foo */; // Foo
/** @psalm-trace $bar */; // Bar

Psalm output (using commit d9c7477):

INFO: Trace - 44:25 - $foo: Foo

INFO: Trace - 45:25 - $bar: Bar

INFO: Trace - 28:29 - $x: list<value-of<class-string-map<T as Foo, T:class-string-map as Foo>>>

INFO: Trace - 32:40 - $class_name: int<0, max>

INFO: Trace - 33:38 - $instance: value-of<class-string-map<T as Foo, T:class-string-map as Foo>>

ERROR: MissingPureAnnotation - 22:26 - get must be marked @psalm-external-mutation-free to aid security analysis, run with --alter --issues=MissingPureAnnotation to fix this