Skip to content

Feat app adapters#63

Merged
abnegate merged 14 commits intomainfrom
feat-app-adapters
Nov 27, 2023
Merged

Feat app adapters#63
abnegate merged 14 commits intomainfrom
feat-app-adapters

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented Nov 2, 2023

What does this PR do?

  • Add Chat adapter base
  • Add Discord adapter
  • Add static analysis
  • Update workflows
  • Update linter

Test Plan

Added discord test

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@eldadfux
Copy link
Copy Markdown
Member

eldadfux commented Nov 7, 2023

@abnegate not sure if we should namespaces them as App adapters. What do you think about Chat?

@abnegate
Copy link
Copy Markdown
Member Author

abnegate commented Nov 8, 2023

@abnegate not sure if we should namespaces them as App adapters. What do you think about Chat?

@eldadfux That works; just though of another option: what do you think about no nested namespace? Since they're not extending a base App/Chat adapter, it could fit better as just Utopia\Messaging\Adapter\Discord

@eldadfux
Copy link
Copy Markdown
Member

eldadfux commented Nov 9, 2023

@eldadfux That works; just though of another option: what do you think about no nested namespace? Since they're not extending a base App/Chat adapter, it could fit better as just Utopia\Messaging\Adapter\Discord

@abnegate I fear it will open a gateway for too much opinionated views and will start seeing to many types without a namespace which at some point could get out of hand.

# Conflicts:
#	src/Utopia/Messaging/Adapter/SMS/GEOSMS.php
#	src/Utopia/Messaging/Adapter/SMS/GEOSMS/CallingCode.php
#	tests/Messaging/Adapter/Email/SendgridTest.php
#	tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php
#	tests/Messaging/Adapter/SMS/GEOSMSTest.php
# Conflicts:
#	composer.json
#	composer.lock
#	src/Utopia/Messaging/Adapter/Push/APNS.php
#	src/Utopia/Messaging/Messages/Email.php
#	src/Utopia/Messaging/Messages/Push.php
#	src/Utopia/Messaging/Messages/SMS.php
#	tests/Messaging/Adapter/Email/EmailTest.php
#	tests/Messaging/Adapter/Email/MailgunTest.php
#	tests/Messaging/Adapter/Email/SendgridTest.php
#	tests/Messaging/Adapter/Push/APNSTest.php
#	tests/Messaging/Adapter/Push/FCMTest.php
#	tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php
#	tests/Messaging/Adapter/SMS/GEOSMSTest.php
#	tests/Messaging/Adapter/SMS/Msg91Test.php
#	tests/Messaging/Adapter/SMS/SMSTest.php
#	tests/Messaging/Adapter/SMS/TelesignTest.php
#	tests/Messaging/Adapter/SMS/TelnyxTest.php
#	tests/Messaging/Adapter/SMS/TwilioTest.php
#	tests/Messaging/Adapter/SMS/VonageTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants