fix: always run headers through external storage regardless of encode_headers#1398
Open
thakoreh wants to merge 1 commit intotemporalio:mainfrom
Open
fix: always run headers through external storage regardless of encode_headers#1398thakoreh wants to merge 1 commit intotemporalio:mainfrom
thakoreh wants to merge 1 commit intotemporalio:mainfrom
Conversation
…_headers The encode_headers/decode_headers flags were gating the entire payload transform pipeline for headers, including external storage store/retrieve and payload size validation. This meant headers could bypass external storage and size validation when encoding was disabled. Split the concern: external storage and validation now always apply to headers. Codec encoding/decoding remains gated by the flag. Changes: - bridge/worker.py: store/validate and retrieve passes always visit headers - client.py: _apply_headers always calls _transform_outbound_payload - worker/_activity.py: always calls _transform_inbound_payload for headers - converter/_data_converter.py: add encode/decode keyword params to _transform_outbound_payload and _transform_inbound_payload - tests: verify store/retrieve happens regardless of encode flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1395
The encode_headers/decode_headers flags were gating the entire payload transform pipeline for headers — including external storage store/retrieve and payload size validation. Headers could bypass external storage when encoding was disabled.
Split the concern: external storage and validation now always apply to headers. Codec encoding/decoding remains gated by the flag.
Changes:
bridge/worker.py: store/validate and retrieve passes always visit headersclient.py:_apply_headersalways calls_transform_outbound_payloadworker/_activity.py: always calls_transform_inbound_payloadfor headersconverter/_data_converter.py: addencode/decodekeyword params