Skip to content

Make dynamic-brokers.md easier to read#206

Merged
Kolaer merged 2 commits intodevelopfrom
documentation/clarity-improvements
Sep 27, 2023
Merged

Make dynamic-brokers.md easier to read#206
Kolaer merged 2 commits intodevelopfrom
documentation/clarity-improvements

Conversation

@Kolaer
Copy link
Contributor

@Kolaer Kolaer commented Sep 26, 2023

I think after these changes, the article is somewhat easier to read. There are still some rough edges, but we can focus on them later.

I can go through the docs and fix everything that I can find, but it'll take some time, so let's start with some smaller changes first.

@Kolaer Kolaer requested a review from s3rius September 26, 2023 17:54
@Kolaer Kolaer self-assigned this Sep 26, 2023
@Kolaer
Copy link
Contributor Author

Kolaer commented Sep 26, 2023

Hi, @s3rius

Please proof-read the changes. I'm not 100% sure that they are in sync with the code/examples.

@codecov-commenter
Copy link

Codecov Report

Merging #206 (d6a1726) into master (04dd68d) will increase coverage by 11.05%.
Report is 126 commits behind head on master.
The diff coverage is 73.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master     #206       +/-   ##
===========================================
+ Coverage   61.94%   72.99%   +11.05%     
===========================================
  Files          37       48       +11     
  Lines         938     1518      +580     
===========================================
+ Hits          581     1108      +527     
- Misses        357      410       +53     
Files Coverage Δ
taskiq/__init__.py 100.00% <100.00%> (ø)
taskiq/abc/formatter.py 100.00% <100.00%> (ø)
taskiq/abc/middleware.py 100.00% <ø> (ø)
taskiq/abc/result_backend.py 100.00% <ø> (ø)
taskiq/abc/schedule_source.py 100.00% <100.00%> (ø)
taskiq/acks.py 100.00% <100.00%> (ø)
taskiq/api/__init__.py 100.00% <100.00%> (ø)
taskiq/brokers/inmemory_broker.py 96.55% <100.00%> (+34.28%) ⬆️
taskiq/cli/watcher.py 0.00% <ø> (ø)
taskiq/cli/worker/log_collector.py 100.00% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to read, indeed. Thank you very much.

@s3rius s3rius changed the base branch from master to develop September 27, 2023 09:31
@Kolaer Kolaer merged commit feb2481 into develop Sep 27, 2023
@s3rius s3rius deleted the documentation/clarity-improvements branch September 28, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants