Make dynamic-brokers.md easier to read#206
Merged
Conversation
Contributor
Author
|
Hi, @s3rius Please proof-read the changes. I'm not 100% sure that they are in sync with the code/examples. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #206 +/- ##
===========================================
+ Coverage 61.94% 72.99% +11.05%
===========================================
Files 37 48 +11
Lines 938 1518 +580
===========================================
+ Hits 581 1108 +527
- Misses 357 410 +53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
s3rius
approved these changes
Sep 27, 2023
Member
s3rius
left a comment
There was a problem hiding this comment.
It's easier to read, indeed. Thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think after these changes, the article is somewhat easier to read. There are still some rough edges, but we can focus on them later.
I can go through the docs and fix everything that I can find, but it'll take some time, so let's start with some smaller changes first.