Refactor TinyGo API into separate packages #183
Merged
danielledeleo merged 6 commits intomainfrom Dec 14, 2021
Merged
Conversation
added 5 commits
November 20, 2021 16:40
Note: breaks existing runnables (see tests for changes)
cohix
approved these changes
Dec 7, 2021
Contributor
cohix
left a comment
There was a problem hiding this comment.
One thing to check on, otherwise this looks great!
|
|
||
| if size < 0 { | ||
| if size == -1 { | ||
| return nil, runnable.NewHostError("unknown error returned from host") |
Contributor
There was a problem hiding this comment.
Do the other languages return here? I'm wondering because not calling get_ffi_result can cause the host to retain that data in the buffer and can cause issues for subsequent host calls. Can't remember if a -1 error from the host means it never filled the buffer at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: breaks existing runnables (see tests for changes)