Releasing issues

[philvarner]

1. dependency github (and maybe another?) must be installed to run the release script. These should be added to the dev dependencies.
2. RELEASING.md needs a note that you must use a "classic" PAT token with at least "admin" grant (or whatever those things are called). "fine-grained" tokens will not work.

[gadomski]

dependency github (and maybe another?) must be installed to run the release script. These should be added to the dev dependencies.

pystapi/pyproject.toml

Line 25 in 0f36066

"pygithub>=2.6.1",

RELEASING.md needs a note that you must use a "classic" PAT token with at least "admin" grant (or whatever those things are called). "fine-grained" tokens will not work.

👍🏼 ... though strange you can't use "fine-grained". I'd be happy to take up modifications to the script that allow other auth mechanisms, too.

Would it help to also make instructions on manually creating the release? There's nothing really magic about the script, it's meant as a convenience to make sure you get the tag format correct, since that's how we figure out which package we're releasing:

pystapi/.github/workflows/release.yaml

Lines 9 to 20 in 0f36066

	package_name:
	name: Get package name
	runs-on: ubuntu-latest
	outputs:
	package_name: ${{ steps.split.outputs.package_name }}
	steps:
	- name: Get repo name
	# https://stackoverflow.com/questions/73402042/github-action-expressions-split-string
	env:
	TAG: ${{ github.ref_name }}
	id: split
	run: echo "package_name=${TAG%%/*}" >> $GITHUB_OUTPUT

[philvarner]

I'd actually already figured out what the pygithub issue was and forgotten -- my venv wasn't automatically activating for some reason.

I'd personally prefer just do do a manual one, since you have to edit it to add the CHANGELOG anyway -- I feel anxious about running a script that requires arguments anyway, especially when I don't do it frequently, and it uses my GH credentials.