Consistently use 'long int' for return of size functions#3086
Consistently use 'long int' for return of size functions#3086
Conversation
|
This should probably be |
SteveBronder
left a comment
There was a problem hiding this comment.
Once tests pass this looks good to me
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Summary
Closes #3085
Tests
Side Effects
I certainly hope we weren't relying on something like these having wrapping semantics.
Release notes
Functions concerned with the number of entries in a container (
size,cols,rows, ...) consistently uselong intas their return type.Checklist
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested