Clean up experiments that are gone, stopped or a winner has been chosen#373
Merged
andrew merged 1 commit intosplitrb:masterfrom Apr 22, 2016
Merged
Clean up experiments that are gone, stopped or a winner has been chosen#373andrew merged 1 commit intosplitrb:masterfrom
andrew merged 1 commit intosplitrb:masterfrom
Conversation
Member
|
Looking good @andreibondarev, can you add a note to the readme about the change in behaviour? |
Member
|
@andreibondarev also have some test fails on travis, can you investigate? https://travis-ci.org/splitrb/split/builds/124871254 |
User class fix, adding specs cleaned up old experiments on Trial.choose since user is memoized; also cleaned up experiments that have not started Fix specs Remove pry Add whitespace Reword a user spec description Fix specs Add the README note
4952231 to
a1bc236
Compare
Contributor
Author
|
@andrew Addressed your feedback |
Member
|
Wonderful, thanks @andreibondarev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
config.allow_multiple_experiments = true, if the user has previous been in any experiment, that is gone, stopped, or a winner has been chosen, he/she will not be placed in a new experiment. The proposed solution creates a new abstraction class User and cleans up old experiments that are no longer active (i.e. gone, stopped or a winner has been chosen)Addresses: #337 (comment)