Skip to content

[AI] Refactor interpreter to support streaming/chunked input#2096

Draft
KCarretto wants to merge 1 commit intomainfrom
jules/eldritch-streaming-interpreter-15533474734514372472
Draft

[AI] Refactor interpreter to support streaming/chunked input#2096
KCarretto wants to merge 1 commit intomainfrom
jules/eldritch-streaming-interpreter-15533474734514372472

Conversation

@KCarretto
Copy link
Collaborator

This change refactors the core Interpreter in eldritch-core to enable streaming or chunked input. It introduces an internal buffer to accumulate multi-line statements sequentially, parsed and executed automatically once complete. is_unexpected_eof correctly distinguishes fatal syntax errors from genuine 'NeedsMoreInput' conditions by inspecting the error message content and the location of the span relative to the end of input.


PR created automatically by Jules for task 15533474734514372472 started by @KCarretto

- Added `InterpretResult` enum (`Complete`, `NeedsMoreInput`, `Error`).
- Added `buffer` field to `Interpreter` struct.
- Refactored `interpret` logic into `interpret_chunk` for accumulating incomplete inputs.
- Implemented `is_unexpected_eof` helper to heuristically detect EOF errors needing more input vs fatal syntax errors.
- Kept `interpret` wrapper method backwards compatible.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2820    ±0 2820    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1750 2820 2820 0 0 0 0 39.8s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2820 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant