Open
Conversation
andre-senna
reviewed
Apr 15, 2026
|
|
||
| ## **Prerequisites** | ||
|
|
||
| Before running the Context Broker, ensure that the following environment variables are properly exported (or set in `.env` file): |
Contributor
There was a problem hiding this comment.
Just checking... Nothing to add to the README after these changes?
|
|
||
| ## **Prerequisites** | ||
|
|
||
| Before running the Query Agent, ensure that the following environment variables are properly exported: |
Contributor
There was a problem hiding this comment.
Just checking... Nothing to add to the README after these changes?
| ~AtomDBSingleton() {} | ||
| static void init( | ||
| atomdb_api_types::ATOMDB_TYPE atomdb_type = atomdb_api_types::ATOMDB_TYPE::REDIS_MONGODB); | ||
| static void init(atomdb_api_types::ATOMDB_TYPE atomdb_type, |
Contributor
There was a problem hiding this comment.
Why do we need to pass atomdb_type separately? Isn't it in the JSON?
| } No newline at end of file | ||
| } | ||
|
|
||
| commons::JsonConfig Helper::default_atomdb_json_config() { |
Contributor
There was a problem hiding this comment.
Why do we need such a default JSON? And why does it have only MongoDB configuration?
If possible, I'd prefer not having a default JSON at all, forcing the caller to always explicitly using one.
|
|
||
| #include "FitnessFunctionRegistry.h" | ||
| #include "Helper.h" | ||
| #include "JsonConfigParser.h" |
Contributor
There was a problem hiding this comment.
Skipping the revision of this because I understand it will change after the discussion we had in our team sync call earlier today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the ENV VARs from the code base (mostly regarding AtomDB).
The idea is getting those values from a give
JsonConfignow.Where we once used default/test values, I created a helper functions to build a
JsonConfigobject with those values.TODO:
bus_clientis still not using the"param"section from theJsonConfig, that will be implemented in a following PR.