Convert keyboard app About tab to SwiftUI (#608)#645
Open
prince-0408 wants to merge 4 commits intoscribe-org:mainfrom
Open
Convert keyboard app About tab to SwiftUI (#608)#645prince-0408 wants to merge 4 commits intoscribe-org:mainfrom
prince-0408 wants to merge 4 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
980917a to
1c82d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the About tab of the Scribe keyboard app from UIKit to SwiftUI, following the pattern established in #607 for the Conjugate app.
Closes #608
Changes
New SwiftUI Files
AboutTab.swiftAboutRowView.swiftAboutSectionView.swiftAboutTipCardView.swiftAboutInfoView.swiftShareSheet.swiftModified Files
AppScreen.storyboardAboutHostingController(aUIHostingControllersubclass) instead ofAboutViewController—InformationScreenVCscene fully removedproject.pbxprojAboutViewController.swiftandInformationScreenVC.swiftremoved,AboutHostingController.swiftregisteredDeleted Files
AboutViewController.swiftAboutHostingController— a minimalUIHostingController<AnyView>subclassInformationScreenVC.swiftNavigationLinkAboutTableData.swiftAboutTab.swiftNotes
AboutHostingControlleris the only remaining UIKit code — it is a necessary bridge since the app's root is aUITabBarControllerwired via storyboard. This cannot be removed until the Installation and Settings tabs are also migrated to SwiftUI, at which point the storyboard andAppDelegatecan be replaced with a SwiftUIAppentry pointMFMailComposeViewControllerviaUIViewControllerRepresentablewith a fallback alert for devices that can't send mailinstallationTipCardState,settingsTipCardState,aboutTipCardStatescribe-org/Scribe-iOSUpdate
Updated based on feedback from @andrewtavis — removed all UIKit related code (
AboutViewControllerandInformationScreenVC) entirely. Replaced with a minimalAboutHostingController(UIHostingControllersubclass) as the only remaining bridge, which is necessary since the app root is still aUITabBarControllerwired via storyboard. This can be fully removed once Installation and Settings tabs are also migrated to SwiftUI.Screenshots