Make overview page display one data point per week#280
Open
OsamaSayegh wants to merge 6 commits intoruby-bench:masterfrom
Open
Make overview page display one data point per week#280OsamaSayegh wants to merge 6 commits intoruby-bench:masterfrom
OsamaSayegh wants to merge 6 commits intoruby-bench:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the overview page (e.g.
/ruby/ruby/commits/overview) tries to display a graph with 2000 data points (BenchmarkRun) for everyBenchmarkType. This is very expensive and takes the page about 5 minutes to load on my local instance.This PR changes the overview page so it picks a single commit per week and displays the data point associated with that commit. The page now takes 1.5 seconds to load locally without cache. We already have a 30 minutes cache in place for the page, so we don't have to do the work repeatedly.
Screenshot:
I also added a link to the overview page on the
/benchmarkspage: