feat(network): add query factory library#85
Merged
juanchoperezj merged 10 commits intomasterfrom Dec 20, 2024
Merged
Conversation
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (46%)
|
nicmalegre
approved these changes
Nov 5, 2024
Collaborator
fernandatoledo
left a comment
There was a problem hiding this comment.
Let us know if you need help with the tests :D
asdolo
approved these changes
Dec 17, 2024
Collaborator
fernandatoledo
left a comment
There was a problem hiding this comment.
This PR introduces multiple functionalities: new API hooks, types, query keys, and interceptors. For future PRs, it might be better to split into smaller, more focused PRs for easier review and faster feedback cycles.
fernandatoledo
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Introduces a new approach to handle the query keys of the react-query.
We can now centralize and have a standardized way to declare our query keys, and from that place reuse them without worrying about typos.
Also, new things were added:
Why did you do this?
Previously, we did not have a a consensus or an agreed approach in the community to handle query keys, causing different approaches to appear; using strings only for keys, enums, and others.
Sometimes this causes duplication, typos, or different query keys with the same data.
Who/what does this impact?
Impact the way the query keys are defined.
How did you test this?
Tests updated to match the UI.