Skip to content

refactor: new template version workflow#51

Merged
asdolo merged 1 commit intomasterfrom
refactor/new_template_version_workflow
Sep 5, 2024
Merged

refactor: new template version workflow#51
asdolo merged 1 commit intomasterfrom
refactor/new_template_version_workflow

Conversation

@asdolo
Copy link
Copy Markdown
Collaborator

@asdolo asdolo commented Sep 4, 2024

What does this do?

Remove New GitHub Release (new-github-release.yml) workflow and replace it with an extra step in the New Template Version (new-template-version.yml) workflow.

Why did you do this?

  • To simplify the amount of actions & workflows we have in the repository: The New GitHub Release workflow was only triggered automatically when a new tag is created. There isn't a way to trigger it manually, but even so it was being show in the Actions page.
  • Because the two workflows had a similar name and they may be mistaken with each other. Actually, the New Template Version workflow is the one we can manually trigger, and it WILL create a new GitHub version if it doesn't fail.
  • Because the New GitHub Release workflow was automatically triggered after new-template-version.yml workflow runs successfully. The behaviour is the same after this refactor.

Who/what does this impact?

N/A

How did you test this?

WIP

@asdolo asdolo self-assigned this Sep 4, 2024
@asdolo asdolo requested a review from a team as a code owner September 4, 2024 00:23
@asdolo asdolo requested review from fernandatoledo, guillermomachado, juanchoperezj and marcos09 and removed request for a team September 4, 2024 00:23
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 51%
50% (250/500) 41.59% (94/226) 35.93% (69/192)

😎 Tests Results

Tests Skipped Failures Errors Time
62 0 💤 0 ❌ 0 🔥 27.176s ⏱️
👀 Tests Details • (51%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files5041.5935.9351.04 
report-only-changed-files is enabled. No files were changed in this commit :)

@asdolo asdolo force-pushed the feat/add_deployed_ur_ls_to_cli_and_template_deployments branch from 3beb136 to c57e231 Compare September 4, 2024 00:50
@asdolo asdolo force-pushed the refactor/new_template_version_workflow branch from 59f20b3 to b559d0b Compare September 4, 2024 00:51
@asdolo asdolo force-pushed the feat/add_deployed_ur_ls_to_cli_and_template_deployments branch from c57e231 to 616110f Compare September 4, 2024 16:51
@asdolo asdolo force-pushed the refactor/new_template_version_workflow branch from b559d0b to 0c9bb9e Compare September 4, 2024 16:52
@asdolo asdolo force-pushed the feat/add_deployed_ur_ls_to_cli_and_template_deployments branch from 616110f to db8a2e2 Compare September 5, 2024 14:55
@asdolo asdolo force-pushed the refactor/new_template_version_workflow branch from 0c9bb9e to 58a013b Compare September 5, 2024 14:55
@asdolo asdolo force-pushed the feat/add_deployed_ur_ls_to_cli_and_template_deployments branch from db8a2e2 to 4da88b9 Compare September 5, 2024 15:10
@asdolo asdolo force-pushed the refactor/new_template_version_workflow branch from 58a013b to d1d8c4a Compare September 5, 2024 15:10
Base automatically changed from feat/add_deployed_ur_ls_to_cli_and_template_deployments to master September 5, 2024 15:12
@asdolo asdolo merged commit 5343ffb into master Sep 5, 2024
@asdolo asdolo deleted the refactor/new_template_version_workflow branch September 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants