Skip to content

Chore/readme#41

Merged
fernandatoledo merged 3 commits intomasterfrom
chore/readme
Sep 2, 2024
Merged

Chore/readme#41
fernandatoledo merged 3 commits intomasterfrom
chore/readme

Conversation

@fernandatoledo
Copy link
Copy Markdown
Collaborator

What does this do?

Replaces mentions to obytes for Rootstrap, corresponding attribution is done at the readme, but we'll make this our own and the docs need to reflect that.

Why did you do this?

The readme still had a lot of information from the obytes original one, there are some sections that at this stage I don't think reflect Rootstrap's best interest like contribution to the template, there's still a long way to go before outsider contributors take interest on this template.

Who/what does this impact?

Documentation

How did you test this?

N / A

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 45%
44.6% (223/500) 37.28% (85/228) 30.36% (58/191)

😎 Tests Results

Tests Skipped Failures Errors Time
53 0 💤 0 ❌ 0 🔥 29.011s ⏱️
👀 Tests Details • (45%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files44.637.2830.3645.89 
app0000 
   onboarding.tsx0100008–42

@fernandatoledo fernandatoledo requested a review from asdolo August 30, 2024 15:04
@fernandatoledo fernandatoledo marked this pull request as ready for review August 30, 2024 15:04
@fernandatoledo fernandatoledo requested a review from a team as a code owner August 30, 2024 15:04
@asdolo
Copy link
Copy Markdown
Collaborator

asdolo commented Aug 30, 2024

@fernandatoledo should the PR be pointed to chore/brand branch?

Copy link
Copy Markdown
Collaborator

@asdolo asdolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting shape! 👏

@fernandatoledo fernandatoledo merged commit c026e82 into master Sep 2, 2024
@fernandatoledo fernandatoledo deleted the chore/readme branch September 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants