Merged
Conversation
3550005 to
77ff453
Compare
juanchoperezj
approved these changes
Aug 30, 2024
fernandatoledo
approved these changes
Aug 30, 2024
Base automatically changed from
feat/eas_read_environment_file_from_eas
to
master
August 30, 2024 18:47
77ff453 to
006ba11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
env.jsscript so it can distinguish if a build is being run locally (with the--localflag).build:staging:ios:localandbuild:staging:android:localscripts frompackage.json.Why did you do this?
To avoid having extra scripts when we want to create a local build. We can now do
pnpm build:staging:ios --localinstead ofpnpm build:staging:ios:local.Who/what does this impact?
Devs using the template.
How did you test this?
Running
pnpm build:staging:ios --localandpnpm build:staging:android --localwith and without a local.env.stagingfile and checking that:.env.stagingis missing, or if a value is missing or have a different type than the expected one).