Skip to content

build(expo): refactor local build script#40

Merged
asdolo merged 1 commit intomasterfrom
build/expo_refactor_local_build_script
Aug 30, 2024
Merged

build(expo): refactor local build script#40
asdolo merged 1 commit intomasterfrom
build/expo_refactor_local_build_script

Conversation

@asdolo
Copy link
Copy Markdown
Collaborator

@asdolo asdolo commented Aug 28, 2024

What does this do?

  • Update env.js script so it can distinguish if a build is being run locally (with the --local flag).
  • Remove build:staging:ios:local and build:staging:android:local scripts from package.json.

Why did you do this?

To avoid having extra scripts when we want to create a local build. We can now do pnpm build:staging:ios --local instead of pnpm build:staging:ios:local.

Who/what does this impact?

Devs using the template.

How did you test this?

Running pnpm build:staging:ios --local and pnpm build:staging:android --local with and without a local .env.staging file and checking that:

  1. The environment variables validation script runs. (i.e., it fails if .env.staging is missing, or if a value is missing or have a different type than the expected one).
  2. The build succeeds and the built app has the proper values in their environment variables.

@asdolo asdolo self-assigned this Aug 28, 2024
@asdolo asdolo requested a review from a team as a code owner August 28, 2024 16:07
@asdolo asdolo requested review from fernandatoledo, guillermomachado, juanchoperezj and marcos09 and removed request for a team August 28, 2024 16:07
@asdolo asdolo force-pushed the build/expo_refactor_local_build_script branch from 3550005 to 77ff453 Compare August 28, 2024 16:08
@asdolo asdolo changed the title feat(eas): read environment file from EAS Secrets build(expo): refactor local build script Aug 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 45%
44.6% (223/500) 37.28% (85/228) 30.36% (58/191)

😎 Tests Results

Tests Skipped Failures Errors Time
53 0 💤 0 ❌ 0 🔥 26.871s ⏱️
👀 Tests Details • (45%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files44.637.2830.3645.89 
report-only-changed-files is enabled. No files were changed in this commit :)

Base automatically changed from feat/eas_read_environment_file_from_eas to master August 30, 2024 18:47
@asdolo asdolo force-pushed the build/expo_refactor_local_build_script branch from 77ff453 to 006ba11 Compare August 30, 2024 18:48
@asdolo asdolo enabled auto-merge August 30, 2024 18:50
@asdolo asdolo merged commit eb82215 into master Aug 30, 2024
@asdolo asdolo deleted the build/expo_refactor_local_build_script branch August 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants