Skip to content

test(api): add tests for axios interceptors#35

Closed
asdolo wants to merge 1 commit intomasterfrom
test/api_add_tests_for_axios_interceptors
Closed

test(api): add tests for axios interceptors#35
asdolo wants to merge 1 commit intomasterfrom
test/api_add_tests_for_axios_interceptors

Conversation

@asdolo
Copy link
Copy Markdown
Collaborator

@asdolo asdolo commented Aug 26, 2024

What does this do?

  1. Add missing tests for Axios interceptors.
  2. Update SonarQube config to ignore *.spec.ts, *.spec.tsx and *.test.ts files from analysis: it was only ignoring *.test.tsx files before this change.

Why did you do this?

  1. Because SonarQube was complaining about some untested code for the interceptors.
  2. Because it makes no sense to analyse test files.

Who/what does this impact?

N/A

How did you test this?

Running the new tests locally.

@asdolo asdolo self-assigned this Aug 26, 2024
@asdolo asdolo requested a review from a team as a code owner August 26, 2024 23:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 44%
43.02% (219/509) 37.28% (85/228) 29.89% (58/194)

😎 Tests Results

Tests Skipped Failures Errors Time
52 0 💤 0 ❌ 0 🔥 27.211s ⏱️
👀 Tests Details • (44%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files43.0237.2829.8944.21 
api/common64.443553.3366.66 
   axios.d.ts0000 

@asdolo asdolo force-pushed the test/api_add_tests_for_axios_interceptors branch from 1c64fd9 to 6af8088 Compare August 27, 2024 00:03
@asdolo asdolo force-pushed the test/api_add_tests_for_axios_interceptors branch from 6af8088 to e2e81a2 Compare August 27, 2024 00:09
@asdolo
Copy link
Copy Markdown
Collaborator Author

asdolo commented Aug 27, 2024

Closed on behalf of #34.

@asdolo asdolo closed this Aug 27, 2024
@asdolo asdolo deleted the test/api_add_tests_for_axios_interceptors branch August 27, 2024 20:14
@asdolo asdolo restored the test/api_add_tests_for_axios_interceptors branch August 27, 2024 20:15
@asdolo asdolo deleted the test/api_add_tests_for_axios_interceptors branch August 27, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants