Skip to content

chore(ci): run lint, test and type check on every pull request#24

Merged
asdolo merged 1 commit intomasterfrom
chore/ci_run_lint_test_and_type_check_on_every_pull_request
Aug 5, 2024
Merged

chore(ci): run lint, test and type check on every pull request#24
asdolo merged 1 commit intomasterfrom
chore/ci_run_lint_test_and_type_check_on_every_pull_request

Conversation

@asdolo
Copy link
Copy Markdown
Collaborator

@asdolo asdolo commented Aug 5, 2024

What does this do?

This PR changes the Lint, Test and Type Check GH Actions so they always run on any pull request, and not only the ones having main/master as base branch.

Why did you do this?

Because in some scenarios we have PRs for branches pointing to other branches than main/master and it's nice if we can start running checks on them.

Who/what does this impact?

Template maintainers.

How did you test this?

Still untested. Will edit this comment with more information after these changes are applied.

@asdolo asdolo self-assigned this Aug 5, 2024
@asdolo asdolo requested a review from a team as a code owner August 5, 2024 17:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 42%
41.33% (210/508) 36.72% (83/226) 27.83% (54/194)

😎 Tests Results

Tests Skipped Failures Errors Time
47 0 💤 0 ❌ 0 🔥 27.288s ⏱️
👀 Tests Details • (42%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files41.3336.7227.8342.44 
report-only-changed-files is enabled. No files were changed in this commit :)

@asdolo asdolo force-pushed the chore/ci_run_lint_test_and_type_check_on_every_pull_request branch from 1ff4676 to 080a27f Compare August 5, 2024 17:27
Copy link
Copy Markdown
Collaborator

@fernandatoledo fernandatoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@asdolo asdolo merged commit 213db45 into master Aug 5, 2024
@asdolo asdolo deleted the chore/ci_run_lint_test_and_type_check_on_every_pull_request branch August 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants