chore: add jira board reference and screenshots to the pull request t…#122
Merged
fernandatoledo merged 2 commits intomasterfrom Jun 12, 2025
Merged
chore: add jira board reference and screenshots to the pull request t…#122fernandatoledo merged 2 commits intomasterfrom
fernandatoledo merged 2 commits intomasterfrom
Conversation
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (50%)
|
asdolo
requested changes
May 16, 2025
Collaborator
asdolo
left a comment
There was a problem hiding this comment.
I love these changes, thanks 🙌 !
Just one little thing. In the CLI project we have a script that searchs for the "What does this do?" section and we remove all text found above that match. Since now we have the new "Jira board reference" section above we may need to change the CLI script to search for that section instead.
You can view it over here:
react-native-template/cli/setup-project.js
Line 133 in 24b4b63
asdolo
approved these changes
May 16, 2025
ManuViola77
approved these changes
Jun 6, 2025
nicmalegre
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…emplate
What does this do?
This PR updates the PULL REQUEST template file.
Why did you do this?
As part of a one of our React Native community roundtables we had a discussion about code review. What were some challenges we faced while reviewing some of our pull requests. One of the things that came up was how sometimes the description of the pull request did not provide with the necessary information to make an accurate review of the introduced changes.
Who/what does this impact?
This would have an impact on the experience of code reviewers.
How did you test this?
A template very similar to this was used in a Rootstrap Project for about 3 months and positive feedback was gathered from the code reviewers of that project.