Merged
Conversation
6faaa91 to
2409f24
Compare
20e5b54 to
cd015a7
Compare
fernandatoledo
approved these changes
Dec 2, 2024
Collaborator
fernandatoledo
left a comment
There was a problem hiding this comment.
Do you think a check to validate if the template-version input is a valid version string?
Collaborator
Author
@fernandatoledo I tried with an invalid string ("hello") and the whole workflow just fails saying "fatal: couldn't find remote ref hello", which is what we want. What do you think? |
cd015a7 to
4c6ee6b
Compare
juanchoperezj
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
upstream-to-pr.ymlworkflow.sync-with-upstream.ymlworkflow with the following changes:template-versioninput to the workflow to manually indicate to which upstream version the template needs to be updated.sync-with-template.ymlworkflow.cliscript.Why did you do this?
To introduce the following new features:
masterbranch, which can be unstable.releasefield:iosandandroiddirectories can now be ignored, as they are no longer pushed to the repository.Who/what does this impact?
New and current users of the template. Please read instructions in
.github/project-workflows/sync-with-template.ymlto setup the new workflow.How did you test this?
I created a private fork of the template, pushed the new workflow to the
masterbranch (so it can be used) and tested different scenarios.