Skip to content

refactor: colocate @react-email/column source in react-email#3236

Merged
gabrielmfern merged 4 commits intostack/01b-colocate-bodyfrom
stack/05-colocate-column
Apr 13, 2026
Merged

refactor: colocate @react-email/column source in react-email#3236
gabrielmfern merged 4 commits intostack/01b-colocate-bodyfrom
stack/05-colocate-column

Conversation

@gabrielmfern
Copy link
Copy Markdown
Member

@gabrielmfern gabrielmfern commented Apr 10, 2026 •
edited
Loading

Summary

  • Colocates the @react-email/column component source into the react-email package

Stack: 6/11 — Depends on #3235

@gabrielmfern gabrielmfern requested a review from joaopcm April 10, 2026 20:30
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 318353a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Error Error Apr 13, 2026 3:26pm
react-email-demo Error Error Apr 13, 2026 3:26pm
react-email-examples Error Error Apr 13, 2026 3:26pm

Request Review

@gabrielmfern gabrielmfern mentioned this pull request Apr 10, 2026
Merged
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 10, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/column@3236

npm i https://pkg.pr.new/react-email@3236

commit: aff5a51

@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 32667c6 to 1ecfed5 Compare April 10, 2026 20:36
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from 65e9153 to 8305b7d Compare April 10, 2026 20:36
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from 8305b7d to 196fbb5 Compare April 10, 2026 20:37
@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 1ecfed5 to 1323ade Compare April 10, 2026 20:37
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from 196fbb5 to aff5a51 Compare April 10, 2026 20:47
@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 1323ade to 8a1ce71 Compare April 10, 2026 20:47
@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 8a1ce71 to 7618b9f Compare April 10, 2026 20:51
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from aff5a51 to 3bd6584 Compare April 10, 2026 20:51
@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 7618b9f to 0148073 Compare April 13, 2026 15:19
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from 3bd6584 to 7972ece Compare April 13, 2026 15:19
@gabrielmfern gabrielmfern force-pushed the stack/04-colocate-code-inline branch from 0148073 to a1ef784 Compare April 13, 2026 15:24
Base automatically changed from stack/04-colocate-code-inline to stack/01b-colocate-body April 13, 2026 15:24
@gabrielmfern
refactor: colocate @react-email/button source in react-email
7d7a419 
Move button implementation under packages/react-email/src/components/button.
Point @react-email/button build at the shared entry and run tests from there.
Add @react-email/render for component specs, widen tsconfig for TSX, and fix
demo emails path in get-emails-directory-metadata spec.

Made-with: Cursor
@gabrielmfern
chore: remove standalone packages/button package
259683b 
Made-with: Cursor
@gabrielmfern
refactor: colocate @react-email/column source in react-email
d7350be 
Made-with: Cursor
@gabrielmfern
chore: remove standalone packages/column package
318353a 
Made-with: Cursor
@gabrielmfern gabrielmfern force-pushed the stack/05-colocate-column branch from 7972ece to 318353a Compare April 13, 2026 15:25
@gabrielmfern gabrielmfern merged commit d349ac0 into stack/01b-colocate-body Apr 13, 2026
5 of 11 checks passed
@gabrielmfern gabrielmfern deleted the stack/05-colocate-column branch April 13, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@joaopcm joaopcm joaopcm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrielmfern @joaopcm