fix(editor): render Table as native <table> instead of Section to fix invalid nesting#3219
Draft
bukinoshita wants to merge 1 commit intocanaryfrom
Draft
fix(editor): render Table as native <table> instead of Section to fix invalid nesting#3219bukinoshita wants to merge 1 commit intocanaryfrom
<table> instead of Section to fix invalid nesting#3219bukinoshita wants to merge 1 commit intocanaryfrom
Conversation
… invalid nesting The Table node's renderToReactEmail method was using Section, which wraps children in its own <table><tbody><tr><td>...</td></tr></tbody></table> structure. This caused TableRow (<tr>) and TableCell (<td>) children to be nested inside a <td> without a nested <table>, producing invalid HTML that email clients repair inconsistently. Replace Section with a native <table> element that wraps children in a <tbody>, producing the correct structure: <table><tbody><tr><td>...</td></tr></tbody></table> Resolves BU-670 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Render the editor’s Table as a native
<table>instead ofSectionto eliminate invalid<tr>inside<td>nesting. This fixes broken layouts in email clients and fulfills Linear BU-670.Sectionfrom@react-email/componentswith a native<table>that wraps children in<tbody>.align,width,border=0,cellPadding=0,cellSpacing=0,role="presentation", and centering styles.<tr>inside<td>and updated snapshots.Written for commit 8e1b4c3. Summary will update on new commits.