Skip to content

fix(editor): preserve button href through HTML round-trip#3217

Merged
bukinoshita merged 2 commits intocanaryfrom
fix/button-href-roundtrip-9673
Apr 13, 2026
Merged

fix(editor): preserve button href through HTML round-trip#3217
bukinoshita merged 2 commits intocanaryfrom
fix/button-href-roundtrip-9673

Conversation

@bukinoshita
Copy link
Copy Markdown
Member

@bukinoshita bukinoshita commented Apr 9, 2026 •
edited
Loading

Summary

The button extension serializes href into a data-href attribute in renderHTML but never maps it back during parseHTML. This means any HTML round-trip (e.g. getHTML() → setContent(), copy/paste, or persist/reload) causes the button's link to be lost, falling back to the default #.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Apr 13, 2026 5:47pm
react-email-demo Ready Ready Preview, Comment Apr 13, 2026 5:47pm
react-email-examples Ready Ready Preview, Comment Apr 13, 2026 5:47pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 571573c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package "playground" depends on the ignored package "email-dev", but "playground" is not being ignored. Please add "playground" to the `ignore` option.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 9, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3217

commit: 571573c

@bukinoshita bukinoshita marked this pull request as ready for review April 13, 2026 17:11
@bukinoshita
Copy link
Copy Markdown
Member Author

bukinoshita commented Apr 13, 2026

@cursor can you fix conflicts please?

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 13, 2026 •
edited
Loading

Conflicts resolved. I rebased the branch onto the latest canary, which had changed @react-email/components imports to react-email. The conflict was in button.spec.tsx where the import path diverged — I kept the new react-email import and preserved all the round-trip test additions. All 42 test files pass and the branch has been force-pushed.

Open in Web Open in Cursor 

@cursoragent @bukinoshita
fix(editor): preserve button href through HTML round-trip
2288f5e 
The button extension was serializing href only as data-href in
renderHTML, and parseHTML never mapped data-href back to href.
This caused buttons to lose their link (falling back to '#') after
any HTML round-trip (getHTML -> setContent, copy/paste, persist/reload).

Changes:
- renderHTML: emit both href and data-href attributes on the <a> tag
- parseHTML: map data-href back to href when building node attributes
- Add tests for full round-trip and data-href-only parsing

Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
@cursor cursor bot force-pushed the fix/button-href-roundtrip-9673 branch from c9b1ae6 to 2288f5e Compare April 13, 2026 17:44
@cursoragent @bukinoshita
fix: sort imports to satisfy biome organizeImports
571573c 
Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
@bukinoshita bukinoshita merged commit 53282f1 into canary Apr 13, 2026
17 checks passed
@bukinoshita bukinoshita deleted the fix/button-href-roundtrip-9673 branch April 13, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@gabrielmfern gabrielmfern gabrielmfern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bukinoshita @gabrielmfern @cursoragent