Skip to content

fix: treat paragraphs with inline leaf nodes as non-empty #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bukinoshita wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

fix: treat paragraphs with inline leaf nodes as non-empty #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/editor/src/core/is-document-visually-empty.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const schema = new Schema({
globalContent: { group: 'block', atom: true },
container: { group: 'block', content: 'block+' },
image: { group: 'block', atom: true },
hardBreak: { group: 'inline', inline: true, selectable: false },
},
});

Expand Down Expand Up @@ -62,6 +63,25 @@ describe('isDocumentVisuallyEmpty', () => {
expect(isDocumentVisuallyEmpty(doc)).toBe(false);
});

it('returns false when paragraph contains only a hardBreak', () => {
const doc = schema.node('doc', null, [
schema.node('paragraph', null, [schema.node('hardBreak')]),
]);

expect(isDocumentVisuallyEmpty(doc)).toBe(false);
});

it('returns false when paragraph contains a hardBreak alongside text', () => {
const doc = schema.node('doc', null, [
schema.node('paragraph', null, [
schema.text('hello'),
schema.node('hardBreak'),
]),
]);

expect(isDocumentVisuallyEmpty(doc)).toBe(false);
});

it('considers just white spaces as not empty', () => {
const doc = schema.node('doc', null, [
schema.node('paragraph', null, [schema.text(' ')]),
Expand Down Expand Up @@ -110,6 +130,16 @@ describe('isDocumentVisuallyEmpty', () => {
expect(isDocumentVisuallyEmpty(doc)).toBe(false);
});

it('returns false when container holds a paragraph with only a hardBreak', () => {
const doc = schema.node('doc', null, [
schema.node('container', null, [
schema.node('paragraph', null, [schema.node('hardBreak')]),
]),
]);

expect(isDocumentVisuallyEmpty(doc)).toBe(false);
});

it('returns false when container holds an image node', () => {
const doc = schema.node('doc', null, [
schema.node('container', null, [schema.node('image')]),
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/core/is-document-visually-empty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ function hasOnlyEmptyParagraph(node: Node): boolean {
}

function isEmptyParagraph(node: Node): boolean {
return node.type.name === 'paragraph' && node.textContent.length === 0;
return node.type.name === 'paragraph' && node.childCount === 0;
}
Loading