Skip to content

Make putting large objects work.#411

Merged
robertnishihara merged 34 commits intoray-project:masterfrom
pcmoritz:large-objects
Apr 5, 2017
Merged

Make putting large objects work.#411
robertnishihara merged 34 commits intoray-project:masterfrom
pcmoritz:large-objects

Conversation

@pcmoritz
Copy link
Copy Markdown
Contributor

@pcmoritz pcmoritz commented Mar 29, 2017 •
edited by robertnishihara
Loading

This should address #412.

@pcmoritz pcmoritz changed the title Make putting large objects work [WIP] Make putting large objects work Mar 29, 2017
@robertnishihara
Copy link
Copy Markdown
Collaborator

robertnishihara commented Mar 30, 2017 •
edited
Loading

Let's hold off on merging this due to https://issues.apache.org/jira/browse/ARROW-739. Although actually this problem may already be present in the Arrow commit in the current master.

@robertnishihara
Copy link
Copy Markdown
Collaborator

robertnishihara commented Mar 31, 2017

Since https://issues.apache.org/jira/browse/ARROW-739 was addressed by apache/arrow@ad8a0cf, can you change this patch to use the most recent arrow commit?

@robertnishihara robertnishihara mentioned this pull request Apr 1, 2017
Closed
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 1, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/470/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 2, 2017

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 2, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/477/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 2, 2017

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 2, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/478/
Test PASSed.

robertnishihara
robertnishihara reviewed Apr 4, 2017
View reviewed changes
Comment thread test/jenkins_tests/run_multi_node_tests.sh
--docker-image=$DOCKER_SHA \
--num-nodes=5 \
--test-script=/ray/test/jenkins_tests/multi_node_tests/test_0.py

Copy link
Copy Markdown
Collaborator

@robertnishihara robertnishihara Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the tests in Jenkins may just be that we were starting the docker image with a small amount of shared memory (1GB), so maybe it would be sufficient to just increase that number.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/497/
Test PASSed.

@robertnishihara robertnishihara changed the title [WIP] Make putting large objects work Make putting large objects work Apr 5, 2017
@robertnishihara robertnishihara changed the title Make putting large objects work Make putting large objects work. Apr 5, 2017
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/498/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/499/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/501/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 5, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/503/
Test PASSed.

@robertnishihara robertnishihara merged commit 4043769 into ray-project:master Apr 5, 2017
@robertnishihara robertnishihara deleted the large-objects branch April 5, 2017 08:04
@robertnishihara robertnishihara mentioned this pull request Apr 5, 2017
Closed
@pcmoritz
Copy link
Copy Markdown
Contributor Author

pcmoritz commented Apr 5, 2017

This validates that arrow's large object support apache/arrow#455 and apache/arrow#404 is working for us end-to-end

Myasuka pushed a commit to Myasuka/ray that referenced this pull request Aug 11, 2025
@wumuzi520
[2/N][VirtualClusetr] add GcsVirtualClusterTable (ray-project#411)
153b731 
Co-authored-by: 黑驰 <senlin.zsl@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcmoritz @robertnishihara @AmplabJenkins