Merged
Conversation
Use Installation Access Token instead of Personal Access token. Note that the Personal Access Token is still needed during cherry-picking/backport process, as there is no GitHub API for cherry-picking.
Member
Author
|
I still need to do some testing. Don't merge yet. |
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 356 357 +1
Branches 29 29
=========================================
+ Hits 356 357 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Tested on my personal repo and personal bot: Original PR: Mariatta/cpython_for_test#2 Backport PR created by app: Mariatta/cpython_for_test#3 |
Member
Author
|
You can compare with how we did the conversion for bedevere: python/bedevere#569 |
Member
Author
|
GitHub App settings:
Permissions & events:
Subscribe to events:
|
Member
Author
|
During deployment, we realized additional things:
After those are sorted out, things seem to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Installation Access Token instead of Personal Access token.
Note that the Personal Access Token is still needed during cherry-picking/backport process, as there is no GitHub API for cherry-picking.
Deployment tasks:
GH_APP_ID,GH_PRIVATE_KEY(from the newly created GitHub App in the previous step)