[3.10] bpo-42972: Track sqlite3 statement objects (GH-26475)#26515
Merged
vstinner merged 2 commits intopython:3.10from Jun 3, 2021
Merged
[3.10] bpo-42972: Track sqlite3 statement objects (GH-26475)#26515vstinner merged 2 commits intopython:3.10from
vstinner merged 2 commits intopython:3.10from
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate and track statement objects in pysqlite_statement_create.
By allocating and tracking creation of statement object in
pysqlite_statement_create(), the caller does not need to worry about GC
syncronization, and eliminates the possibility of getting a badly
created object. All related fault handling is moved to
pysqlite_statement_create().
Co-authored-by: Victor Stinner vstinner@python.org.
(cherry picked from commit fffa0f9)
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no
https://bugs.python.org/issue42972