gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417
Open
hoodmane wants to merge 6 commits intopython:mainfrom
Open
gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417hoodmane wants to merge 6 commits intopython:mainfrom
hoodmane wants to merge 6 commits intopython:mainfrom
Conversation
Member
|
The test suite fails on Emscripten with |
vstinner
reviewed
Mar 30, 2026
| * https://github.com/emscripten-core/emscripten/blob/1aa7fb531f11e11e7ae49b75a24e1a8fe6fa4a7d/src/lib/libtty.js?plain=1#L104-L114 | ||
| * | ||
| * Ideally some version of this should go upstream to Emscripten since it is not | ||
| * in any way specific to Python. But I haven't gotten around to it yet. |
Member
There was a problem hiding this comment.
Can you specify who is "I" in this sentence?
Suggested change
| * in any way specific to Python. But I haven't gotten around to it yet. | |
| * in any way specific to Python. But I (Hood) haven't gotten around to it yet. |
| // an O_NONBLOCK file descriptor. Synchronously sleep for 100ms as | ||
| // requested by EAGAIN and try again. In case for some reason we fail to | ||
| // sleep, propagate the error (it will turn into an EOFError). | ||
| if (syncSleep(100)) { |
Member
There was a problem hiding this comment.
100 ms sounds high to me. What about 10 ms?
| } | ||
| if (nbytes === undefined) { | ||
| // Prevent an infinite loop caused by incorrect code that doesn't return a | ||
| // value |
Member
There was a problem hiding this comment.
Suggested change
| // value | |
| // value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.