gh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h#146229
Merged
colesbury merged 1 commit intopython:mainfrom Mar 20, 2026
Merged
gh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h#146229colesbury merged 1 commit intopython:mainfrom
colesbury merged 1 commit intopython:mainfrom
Conversation
…_std.h Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @colesbury, I could not cleanly backport this to |
|
Sorry, @colesbury, I could not cleanly backport this to |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2026
…yatomic_std.h (pythongh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-146232 is a backport of this pull request to the 3.14 branch. |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2026
…yatomic_std.h (pythongh-146229) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-146233 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Mar 20, 2026
…c_std.h (gh-146229) (#146232) Also fix a few related issues in the pyatomic headers: * Fix _Py_atomic_store_uint_release in pyatomic_msc.h to use __stlr32 on ARM64 instead of a plain volatile store (which is only relaxed on ARM64). * Add missing _Py_atomic_store_uint_release to pyatomic_gcc.h. * Fix pseudo-code comment for _Py_atomic_store_ptr_release in pyatomic.h. (cherry picked from commit 1eff27f)
colesbury
added a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a few related issues in the pyatomic headers:
_Py_atomic_store_uint_releasein pyatomic_msc.h to use__stlr32on ARM64 instead of a plain volatile store (which is only relaxed on ARM64)._Py_atomic_store_uint_releaseto pyatomic_gcc.h._Py_atomic_store_ptr_releasein pyatomic.h._Py_atomic_load_uint16incorrect inpyatomic_std.h#146227