Skip to content

[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697)#125255

Merged
pablogsal merged 2 commits intopython:3.10from
encukou:backport-26e06ad-3.10
Oct 22, 2024
Merged

[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697)#125255
pablogsal merged 2 commits intopython:3.10from
encukou:backport-26e06ad-3.10

Conversation

@encukou
Copy link
Copy Markdown
Member

@encukou encukou commented Oct 10, 2024

This skips tarfile's chmod-related tests on

  • systems where setting suid/sgid is no-op (which are unsupported), and
  • systems where setting the sticky bit is an OSError (like the tier-3 FreeBSD)

This also adds a few directory-related tests, which were originally omitted because they failed on some platforms. Now they will be skipped on those platforms.

In 3.11+ this was done with two commits, GH-108368 & GH-109697:

(cherry-picked from 40e52c9)
(cherry-picked from 26e06ad)

One builds on the other. IMO it makes sense to backport it all, so that these tests are the same as in 3.11+.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants