Skip to content

gh-106847: Add -X warn_default_encoding in sys.flags Doc#106854

Merged
kumaraditya303 merged 5 commits intopython:mainfrom
qqwqqw689:main
Jul 21, 2023
Merged

gh-106847: Add -X warn_default_encoding in sys.flags Doc#106854
kumaraditya303 merged 5 commits intopython:mainfrom
qqwqqw689:main

Conversation

@qqwqqw689
Copy link
Copy Markdown
Contributor

@qqwqqw689 qqwqqw689 commented Jul 18, 2023 •
edited by bedevere-bot
Loading

The table of sys.flags doesn't have warn_default_encoding attribute.
So I add it.

@ghost
Copy link
Copy Markdown

ghost commented Jul 18, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 18, 2023
@sobolevn sobolevn changed the title Add -X warn_default_encoding in sys.falgs Doc gh-106847: Add -X warn_default_encoding in sys.falgs Doc Jul 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 18, 2023
Closed
sobolevn
sobolevn reviewed Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qqwqqw689 qqwqqw689 requested a review from sobolevn July 18, 2023 23:33
@sobolevn sobolevn requested a review from FFY00 July 19, 2023 06:28
@qqwqqw689 qqwqqw689 changed the title gh-106847: Add -X warn_default_encoding in sys.falgs Doc gh-106847: Add -X warn_default_encoding in sys.flags Doc Jul 19, 2023
@methane methane self-requested a review July 20, 2023 12:11
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 21, 2023
@kumaraditya303 kumaraditya303 merged commit fd84ac0 into python:main Jul 21, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 21, 2023

Thanks @qqwqqw689 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 21, 2023

Sorry @qqwqqw689 and @kumaraditya303, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker fd84ac0ee0a8d5e34e0a106eed7e50539b61c5f8 3.12

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 21, 2023

GH-106958 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2023
@qqwqqw689 @sobolevn @miss-islington
pythongh-106847: Add -X warn_default_encoding in sys.flags Doc (pytho…
b9a5b11 
…nGH-106854)

(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
methane pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @qqwqqw689 @sobolevn
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
c332117 
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@methane methane added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 22, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 22, 2023

Thanks @qqwqqw689 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@qqwqqw689 @sobolevn @miss-islington
pythongh-106847: Add -X warn_default_encoding in sys.flags Doc (pytho…
63a60ec 
…nGH-106854)

(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 22, 2023

GH-107054 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
methane pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @qqwqqw689 @sobolevn
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
bd907dc 
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

@FFY00 FFY00 Awaiting requested review from FFY00

Assignees

@kumaraditya303 kumaraditya303

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qqwqqw689 @miss-islington @bedevere-bot @methane @sobolevn @kumaraditya303