Skip to content

Update minimum Python version to 3.9 in the configuration#137

Merged
hugovk merged 2 commits intopython:mainfrom
OlenaYefymenko:complete-dropping-support-python-3.8
Oct 11, 2024
Merged

Update minimum Python version to 3.9 in the configuration#137
hugovk merged 2 commits intopython:mainfrom
OlenaYefymenko:complete-dropping-support-python-3.8

Conversation

@OlenaYefymenko
Copy link
Copy Markdown
Contributor

🍒Update minimum Python version to 3.9 in the configuration

Resolves #136

@ghost
Copy link
Copy Markdown

ghost commented Oct 11, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk hugovk added the hacktoberfest-accepted Accepted for hacktoberfest label Oct 11, 2024
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Oct 11, 2024

Thanks for the PR!

There's some linting to fix.

Please could you run:

python -m pip install pre-commit
pre-commit run --all-files

Or if you use uv, something like this:

uvx pre-commit run --all-files

And commit the changed file?

@OlenaYefymenko
Copy link
Copy Markdown
Contributor Author

Thanks for the PR!

There's some linting to fix.

Please could you run:

python -m pip install pre-commit
pre-commit run --all-files

Or if you use uv, something like this:

uvx pre-commit run --all-files

And commit the changed file?

Thank you for the feedback!
Yes, I can run pre-commit tool
Please advise, should I make changes for test_cherry_picker.py within this PR, or is it better to open a new PR?
I worry about atomic, this is formatted changes and not connected with the Python version.

@zware
Copy link
Copy Markdown
Member

zware commented Oct 11, 2024

IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.

Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))

@OlenaYefymenko
Copy link
Copy Markdown
Contributor Author

IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.

Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))

Thank you for pointing, I added this change.

Copy link
Copy Markdown
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🎃🍒

@hugovk hugovk merged commit 7fdaa08 into python:main Oct 11, 2024
@webknjaz
Copy link
Copy Markdown
Member

@hugovk perhaps, somebody has to enable the pre-commit.ci app for this repo, eh?

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Oct 12, 2024

Good idea, I sent a request via https://pre-commit.ci/ to enable this repo. @JacobCoffee, please can you accept it?

@JacobCoffee
Copy link
Copy Markdown
Member

@hugovk done

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Oct 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted for hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO] Complete dropping support for Python 3.8

5 participants