docs(proposal): add release cooldown design for version resolution#1000
docs(proposal): add release cooldown design for version resolution#1000LalatenduMohanty wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new proposals documentation section and registers it in the main docs index. Introduces Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/proposals/release-cooldown.md`:
- Around line 63-66: The click option for "--min-release-age" currently uses
click.IntRange(min=0) which rejects negatives instead of treating them as 0;
update the option definition for "--min-release-age" to either pass clamp=True
to click.IntRange (e.g., click.IntRange(min=0, clamp=True)) or add a
post-validation normalization for the parameter (e.g., in the command function
that accepts min_release_age, coerce min_release_age = max(0, min_release_age))
so negative inputs become 0; ensure you modify the decorator/option declaration
or the command handler that receives the min_release_age argument (look for the
click.option for "--min-release-age" and the command function parameter
min_release_age).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3059b861-0da5-4cd5-90bf-907fc351cb54
📒 Files selected for processing (3)
docs/index.rstdocs/proposals/index.rstdocs/proposals/release-cooldown.md
37b1f1e to
379b00a
Compare
379b00a to
76500ef
Compare
6e1b98c to
e59ae9e
Compare
See: python-wheel-build#877 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
e59ae9e to
b0f1340
Compare
|
note to reviewers: I've taken another stab at a more full-featured solution to this problem over in #1018 (based on feedback from a number of you in this PR) |
Pull Request Description
What
Add a design proposal for release cooldown -- a configurable minimum release age for version resolution. The proposal introduces a --min-release-age CLI option (days, default 0) that makes fromager skip package versions published fewer than N days ago, with per-package overrides via resolver_dist.min_release_age in package settings.
Why
Supply-chain attacks often publish a malicious package version and rely on automated builds picking it up immediately. A cooldown window lets the community detect and report compromised releases before fromager consumes them.
See: #877