Set min_zoom default to Leaflet value (0 i.o. 1)#791
Merged
ocefpaf merged 2 commits intopython-visualization:masterfrom Dec 7, 2017
Merged
Set min_zoom default to Leaflet value (0 i.o. 1)#791ocefpaf merged 2 commits intopython-visualization:masterfrom
ocefpaf merged 2 commits intopython-visualization:masterfrom
Conversation
Member
|
LGTM (and this one is an easy merge 😉) Thanks @Conengmo! I'll try to find some time to review your other PRs ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the default value for the min_zoom parameter is set to 1, while in Leaflet it is 0. I couldn't find any documentation on this, so I assume it's a (tiny) mistake.
I can imagine that users don't want the
zoom_startto change from 1 to 0, so I set it to 1 instead ofmin_zoom. Ifmin_zoomis higher than 1, Leaflet will automatically change the starting zoom level.