Change Map lat&lon bound type annotations from int to float#1954
Merged
Conengmo merged 1 commit intopython-visualization:mainfrom May 23, 2024
JonasVerbickas:main
Merged
Change Map lat&lon bound type annotations from int to float#1954Conengmo merged 1 commit intopython-visualization:mainfrom JonasVerbickas:main
Map lat&lon bound type annotations from int to float#1954Conengmo merged 1 commit intopython-visualization:mainfrom
JonasVerbickas:main
Conversation
There is no technical reason for why the lat&lon bounds would have to be int. In fact, it makes a lot of sense to use floats in order to allow for much more precise map bounds.
martinfleis
approved these changes
May 22, 2024
Collaborator
martinfleis
left a comment
There was a problem hiding this comment.
good catch. The code actually fully supports floats, it is just wrong type hinting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no technical reason for why the lat&lon bounds would have to be int.
In fact, it makes a lot of sense to use floats in order to allow for much more precise map bounds.