Add a custom container to the realtime plugin#1869
Add a custom container to the realtime plugin#1869Conengmo merged 7 commits intopython-visualization:mainfrom
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Conengmo
left a comment
There was a problem hiding this comment.
Nice addition to this plugin! I've added 3 comments, hope you have time to address them. Afterwards we can get this merged!
No idea why this was gone in this branch.
|
This looks good Hans, the docstring is pretty clear so I hope users can work with this.
Though that does make sense, I'm hesitant from a complexity perspective. Adding a core Folium class doesn't seem to weigh up to facilitating a single type hint for an optional argument in a single plugin. Having too many layers of class inheritance makes things more complicated to understand. So I think I'm fine with how it's solved now. I'll go ahead and merge it now. Thanks for your contribution to Folium! |
Add the container parameter from the leaflet
realtimeplugin to the Foliumrealtimeplugin. So far, only tested withMarkerCluster. Also add tests and improved the documentation.