add local file prefix for browser#1704
Merged
Conengmo merged 1 commit intopython-visualization:mainfrom Jan 20, 2023
Merged
Conversation
Member
|
Thank you Riley! Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The show_in_browser() method wasn't working at all for me -- no browser popped up, but no error thrown. I'm on a M1 13" Macbook Pro running Ventura 13.1 and Python 3.11.1.
Adding a "file://" prefix to the fname makes the browser work as expected. This change doesn't break any tests on my end. Tested on MacOS and Debian, don't have access to a windows machine at the moment.
First PR here so if I've done something horrifyingly wrong, let me know!