WmsTileLayer: allow cql_filter parameter#1673
Merged
Conengmo merged 3 commits intopython-visualization:mainfrom Nov 29, 2022
Merged
WmsTileLayer: allow cql_filter parameter#1673Conengmo merged 3 commits intopython-visualization:mainfrom
Conengmo merged 3 commits intopython-visualization:mainfrom
Conversation
ocefpaf
reviewed
Nov 29, 2022
Comment on lines
+226
to
+228
| if cql_filter: | ||
| # special parameter that shouldn't be camelized | ||
| self.options["cql_filter"] = cql_filter |
Member
There was a problem hiding this comment.
Can we pop it from the kw args to avoid adding an extra arg entry? Not sure if this is best but maybe something like:
cql_filter = kwargs.pop("cql_filter", None)
if cql_filter:
# special parameter that shouldn't be camelized
self.options["cql_filter"] = cql_filter
ocefpaf
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1248
WmsTileLayer users requested a
cql_filterparameter be passed through without converting to lowerCamelCase notation.