TagFilterButton is not a Layer#1671
Merged
Conengmo merged 1 commit intopython-visualization:mainfrom Nov 29, 2022
Merged
Conversation
ocefpaf
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1670
The new TagFilterButton plugin added in #1343 acted like a layer, but it is not a layer but a control. This causes issues when you add both a TagFilterButton and a LayerControl to a map. TagFilterButton shouldn't and cannot show up in the layer control.
Fix this by making TagFilterButton inherit from MacroElement.